Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd(obs-backgroundremoval): 1.1.3 -> 1.1.6 #4576

Merged
merged 2 commits into from
Sep 27, 2023
Merged

upd(obs-backgroundremoval): 1.1.3 -> 1.1.6 #4576

merged 2 commits into from
Sep 27, 2023

Conversation

umireon
Copy link
Contributor

@umireon umireon commented Sep 22, 2023

No description provided.

@github-actions github-actions bot added the Update Package Use this to request pacscript update label Sep 22, 2023
@umireon umireon force-pushed the obs-backgroundremoval-1.1.6 branch 3 times, most recently from 28dc54b to d4023be Compare September 22, 2023 12:17
@umireon umireon mentioned this pull request Sep 22, 2023
Closed
@umireon
Copy link
Contributor Author

umireon commented Sep 22, 2023

All the systems are included in the incompatible field. I didn't change the incompatible field and I don't know why every system is incompatible.

@Elsie19
Copy link
Member

Elsie19 commented Sep 25, 2023

Have you tested on supposed incompatible systems?

@umireon
Copy link
Contributor Author

umireon commented Sep 25, 2023

I think we need to add PPA OBS distribution to pacstall repository first.

@Zahrun
Copy link
Contributor

Zahrun commented Sep 26, 2023 •
edited
Loading

I think we need to add PPA OBS distribution to pacstall repository first.

I met some build dependencies missing in the distros which are in the incompatible field.
One option is to add the ppa to the pacscript, but I preferred to avoid that, so I just excluded the distro versions which couldn’t build with native repos.
I’m fine if you add the ppa though. I think most people will use the -deb version anyway

PS: debian has no ppa support though?

@Zahrun
Copy link
Contributor

Zahrun commented Sep 26, 2023

Have you tested on supposed incompatible systems?

I will test these systems again

@Zahrun
Copy link
Contributor

Zahrun commented Sep 26, 2023 •
edited
Loading

Version 1.1.6 builds fine in jammy and is even compatible with obs 27, which was unexpected
image
PS: locaal-ai/obs-backgroundremoval#451

@Zahrun
Copy link
Contributor

Zahrun commented Sep 26, 2023 •
edited
Loading

Focal fails with

CMake Error: The source directory "/tmp/pacstall/obs-backgroundremoval-1.1.6/linux-ci-x86_64" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.
Error: /tmp/pacstall/obs-backgroundremoval-1.1.6/build_x86_64 is not a directory"

It has cmake 3.16.3 which is supposed to be compatible since https://github.com/royshil/obs-backgroundremoval/pull/250/files

PS: cmake-deb pacscript (3.25.1) is not installable on focal due to missing dependencies

PPS: if I install cmake with pip (3.27.5), I get these errors:

CMake Error in CMakeLists.txt:
  Imported target "OBS::obs-frontend-api" includes non-existent path

    "obs-frontend-api_INCLUDE_DIR-NOTFOUND"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in CMakeLists.txt:
  Imported target "OBS::obs-frontend-api" includes non-existent path

    "obs-frontend-api_INCLUDE_DIR-NOTFOUND"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in CMakeLists.txt:
  Imported target "OBS::obs-frontend-api" includes non-existent path

    "obs-frontend-api_INCLUDE_DIR-NOTFOUND"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



-- Generating done (0.0s)
CMake Warning:
  Manually-specified variables were not used by the project:

    USE_SYSTEM_CURL


CMake Generate step failed.  Build files cannot be regenerated correctly.

@Zahrun
Copy link
Contributor

Zahrun commented Sep 26, 2023

I was able to compile in bullseye by changing qt6-base-dev to qtbase5-dev and adding -DQT_VERSION=5 to cmake arguments. But it fails at loading in obs with:

error: os_dlopen(/usr//lib/x86_64-linux-gnu/obs-plugins/obs-backgroundremoval.so->/usr//lib/x86_64-linux-gnu/obs-plugins/obs-backgroundremoval.so): /usr//lib/x86_64-linux-gnu/obs-plugins/obs-backgroundremoval.so: undefined symbol: __libc_single_threaded

warning: Module '/usr//lib/x86_64-linux-gnu/obs-plugins/obs-backgroundremoval.so' not loaded

@umireon umireon force-pushed the obs-backgroundremoval-1.1.6 branch from c3909cf to 53cce73 Compare September 26, 2023 14:28
@umireon
Copy link
Contributor Author

umireon commented Sep 26, 2023

I don't think our plugin can be built with CMake 3.16.

@Zahrun
Copy link
Contributor

Zahrun commented Sep 26, 2023 •
edited
Loading

I don't think our plugin can be built with CMake 3.16.

Should line 1 of CMakeList be updated? https://github.com/royshil/obs-backgroundremoval/blob/main/CMakeLists.txt#L1

PS: locaal-ai/obs-backgroundremoval#450

Zahrun
Zahrun approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@Zahrun Zahrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umireon Merge in from master for the checks not to fail
Error: The head commit for this pull_request event is not ahead of the base commit.

This was referenced Sep 26, 2023
Closed
Closed
@Elsie19
Copy link
Member

Elsie19 commented Sep 26, 2023

Ok it works, but do we want to try getting it working on all these distros or no?

@umireon
Copy link
Contributor Author

umireon commented Sep 27, 2023

I don't know why the uninstalling test fails. Does this test need to be passed?

@Zahrun
Copy link
Contributor

Zahrun commented Sep 27, 2023 •
edited
Loading

Ok it works, but do we want to try getting it working on all these distros or no?

It works on Ubuntu jammy LTS and more recent, Debian stable, testing, and sid. I consider it’s good enough.

I don't know why the uninstalling test fails. Does this test need to be passed?

This is only a CI issue due to the cmake-deb pacdep. We should be good to merge.

@Elsie19 Elsie19 merged commit 0b9a85c into pacstall:master Sep 27, 2023
8 of 20 checks passed
@Elsie19 Elsie19 changed the title upd(obs-backgroundremoval): 1.1.3 -> 1.1.6 upd(obs-backgroundremoval): 1.1.3 -> 1.1.6 Sep 27, 2023
Zahrun pushed a commit to Zahrun/pacstall-programs that referenced this pull request Oct 11, 2023
@umireon @Elsie19 @Zahrun
upd(obs-backgroundremoval): 1.1.3 -> 1.1.6 (pacstall#4576)
4c64ad9 
Co-authored-by: Elsie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elsie19 Elsie19 Elsie19 approved these changes

@Zahrun Zahrun Zahrun approved these changes

Assignees

@umireon umireon

Labels
Update Package Use this to request pacscript update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umireon @Elsie19 @Zahrun